Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider letting reveal do the code highlighting or dropping it entirely #2

Open
dabrahams opened this issue Jan 15, 2022 · 0 comments

Comments

@dabrahams
Copy link
Collaborator

Aside from being at the root of #1 not being implemented, having jekyll/rouge put the highlights in the HTML makes it much harder to consider scanning code examples with our own plugin, e.g. to look for special annotations that drive animations. It also injects some extra <div>s that cause this CSS to be needed and other kinds of customization to be impossible from markdown.

It would allow us to use reveal's marking when only line-by-line marks are needed the usual case, and save the reveal-mark-plugin for things that need sub-line marking.

I'm not sure why I decided to let jekyll do this job; maybe it was a misguided desire to avoid client-side processing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant