Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releasing a new version #79

Open
skrapi opened this issue Sep 29, 2020 · 8 comments
Open

Releasing a new version #79

skrapi opened this issue Sep 29, 2020 · 8 comments

Comments

@skrapi
Copy link
Contributor

skrapi commented Sep 29, 2020

Is it possible to release a new version with some of the recent changes? If there is anyway I could do it, I would happily put the effort in.

@skrapi skrapi changed the title A new release Releasing a new version Sep 29, 2020
@kim-acmehi
Copy link

@stlehmann @skrapi I would like to see that 1.1.2 released as well so I can dispense with my custom changes. Can we get it released?

@stlehmann
Copy link
Owner

@skrapi @kim-acmehi There is still one issue where Python 3.6 does not pass the tests. But I think I can make a new release this weekend.

@skrapi
Copy link
Contributor Author

skrapi commented Oct 9, 2020

@stlehmann Great, please do let me know if I can help in any way.

@stlehmann
Copy link
Owner

@kim-acmehi, @skrapi sorry to keep you waiting but I'm quite busy at the moment and couldn't manage to draft a new release, yet. If you are not using Python 3.6 then you can already use the newest version by installing the master-branch version directly with pip.

@kim-acmehi
Copy link

@stlehmann I am using Python 3.7 so this is not an issue for me. I know how it goes being busy. I will have a look at the failure in travis-ci and see if I can get a clue why it is failing on Python 3.6. But I might be too busy to get to it this weekend. :)

@kim-acmehi
Copy link

@stlehmann I finally had some time to look at the failing Python 3.6 test. Running deploy.sh by hand with Python 3.6 I found that test_on_topic does pass sometimes but mostly fails. I set up an overnight run of the deploy.sh iterations. Out of about 1150 test runs test_on_topic:

FAILED: 805
PASSED: 350

I did try upping the wait() time from 5 seconds but it did not seem to make any difference. Since it fails more often than not I think the next step to to watch the log messages on the mosquitto server and see how a passing and failing test compares. If you have any other idea please let me know.

@stlehmann
Copy link
Owner

@kim-acmehi thanks for digging into this. I created a new issue for further discussions.

@MrTanoshii
Copy link

@stlehmann
I see the tests are now working and there's been lots of improvements on the paho-mqtt side
Is a new release still underway?

I also noticed a few discrepancies:

flask-mqtt

Location Version
example/ 1.0.5

paho-mqtt

Location Version
example/ 1.5.0
requirements/ 1.4.0
requirements.txt 1.6.1

Should I make a PR to update flask-mqtt to 1.1.2 and paho-mqtt to 1.6.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants