Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better distribution of pyads through platformed wheels #425

Open
RobertoRoos opened this issue Sep 19, 2024 · 0 comments · May be fixed by #426
Open

Better distribution of pyads through platformed wheels #425

RobertoRoos opened this issue Sep 19, 2024 · 0 comments · May be fixed by #426

Comments

@RobertoRoos
Copy link
Contributor

I was thinking about for a little bit and wanted to open issue this issue mostly to host some discussion.

Currently pyads is published only as a source package, no wheels at all: https://pypi.org/project/pyads/#files.
When installed on Linux/Mac, adslib is always compiled during install and the resulting .so library is dumped amidst the pyads source code, where it's dynamically loaded at runtime.

This definitely works, but I feel it's not according to modern standard and could be improved.

I would suggest we distribute mainly as wheels instead. So we'd publish:

  • A wheel for Linux, already including the compiled adslib (and no adslib source)
  • A wheel for MacOS, already including the compiled adslib (and no adslib source)
  • A wheel for Windows, containing only the pyads source and no adslib source or binaries
  • A source distribution for platforms falling through the cracks, with the adslib source and no binaries so they can be compiled during installation

This way most installations shouldn't require any compilation at all.
I'm pretty far with an example of this already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant