Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing behavior of --elm-test option #82

Open
tad-lispy opened this issue Apr 1, 2019 · 1 comment
Open

Confusing behavior of --elm-test option #82

tad-lispy opened this issue Apr 1, 2019 · 1 comment

Comments

@tad-lispy
Copy link
Contributor

Hey! Thanks for this program. It's very useful and I appreciate your effort in creating and maintaining it.

The problem

If I pass a wrong value to --elm-test option the program silently falls back to default elm-test. I believe it's a wrong design choice. I would expect a meaningful error, like:

$ elm-verify-examples --elm-test typoz-here
Error: no such file or directory: typoz-here

The problem is caused here: https://github.com/stoeffel/elm-verify-examples/blob/master/bin/runner.js#L93-L96

Would you be interested in a PR addressing this?

Use case:

I run into this while trying to use your program with elm-coverage. I tried:

elm-verify-examples --elm-test elm-coverage

and it just ran elm-test. I tried:

elm-verify-examples --elm-test 'npx elm-coverage'

Same thing. At this point I looked into source code and found what's going on.

@gampleman
Copy link
Collaborator

👍 PRs welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants