Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update subm-operator to accommodate changes done after operator-sdk upgrade #481

Closed
Jaanki opened this issue Sep 7, 2022 · 4 comments
Closed

Update subm-operator to accommodate changes done after operator-sdk upgrade #481

Jaanki opened this issue Sep 7, 2022 · 4 comments
Assignees
@Jaanki

Comments

@Jaanki
Copy link
Contributor

Jaanki commented Sep 7, 2022 •
edited
Loading

operator-sdk has been upgraded to v1.23.0 for submariner-operator. This entails few changes in the submariner-operator repo. Accordingly make changes in the addon as well like:

  1. submariner apis are now located at api/v1alpha1 and not api/submariner/v1alpha1
  2. submariner operator no longer provides a client/clientset. Remove its usage from the addon.

Part of epic: submariner-io/enhancements#81
@Jaanki
Copy link
Contributor Author

Jaanki commented Sep 7, 2022

/assign @Jaanki

@Jaanki Jaanki mentioned this issue Sep 7, 2022
Closed
9 tasks
Jaanki added a commit to Jaanki/submariner-addon that referenced this issue Sep 7, 2022
@Jaanki
Update submariner-operator to v0.14.0-m1
eb9ea09 
to accommodate changes after operator-sdk upgrade.

1. api/submariner/v1alpha1 -> api/v1alpha1
2. pkg/client usage removed
3. other submariner projects are also updated.

Fixes: stolostron#481
Part of epic: submariner-io/enhancements#81

Signed-off-by: Janki Chhatbar <[email protected]>
@Jaanki Jaanki mentioned this issue Sep 7, 2022
Closed
@Jaanki Jaanki changed the title Update operator to accommodate changes done after operator-sdk upgrade. Update subm-operator to accommodate changes done after operator-sdk upgrade. Sep 7, 2022
@Jaanki Jaanki changed the title Update subm-operator to accommodate changes done after operator-sdk upgrade. Update subm-operator to accommodate changes done after operator-sdk upgrade Sep 7, 2022
Jaanki added a commit to Jaanki/submariner-addon that referenced this issue Sep 7, 2022
@Jaanki
Update submariner-operator to v0.14.0-m1
4618d3a 
to accommodate changes after operator-sdk upgrade.

1. api/submariner/v1alpha1 -> api/v1alpha1
2. pkg/client usage removed
3. other submariner projects are also updated.

Fixes: stolostron#481
Part of epic: submariner-io/enhancements#81

Signed-off-by: Janki Chhatbar <[email protected]>
Jaanki added a commit to Jaanki/submariner-addon that referenced this issue Sep 7, 2022
@Jaanki
Update submariner-operator to v0.14.0-m1
17c3d1e 
to accommodate changes after operator-sdk upgrade.

1. api/submariner/v1alpha1 -> api/v1alpha1
2. pkg/client usage removed
3. other submariner projects are also updated.

Fixes: stolostron#481
Part of epic: submariner-io/enhancements#81

Signed-off-by: Janki Chhatbar <[email protected]>
Jaanki added a commit to Jaanki/submariner-addon that referenced this issue Sep 7, 2022
@Jaanki
Update submariner-operator to v0.14.0-m1
8ad013e 
to accommodate changes after operator-sdk upgrade.

1. api/submariner/v1alpha1 -> api/v1alpha1
2. pkg/client usage removed
3. other submariner projects are also updated.

Fixes: stolostron#481
Part of epic: submariner-io/enhancements#81

Signed-off-by: Janki Chhatbar <[email protected]>
Jaanki added a commit to Jaanki/submariner-addon that referenced this issue Sep 13, 2022
@Jaanki
Update submariner components to v0.14.0-m1
52c0039 
to accommodate changes after operator-sdk upgrade.

1. api/submariner/v1alpha1 -> api/v1alpha1
2. pkg/client usage removed
3. other submariner projects are also updated.

Fixes: stolostron#481
Part of epic: submariner-io/enhancements#81

Signed-off-by: Janki Chhatbar <[email protected]>
Jaanki added a commit to Jaanki/submariner-addon that referenced this issue Sep 24, 2022
@Jaanki
Update submariner components to v0.14.0-m1
b5d4c42 
to accommodate changes after operator-sdk upgrade.

1. api/submariner/v1alpha1 -> api/v1alpha1
2. pkg/client usage removed
3. other submariner projects are also updated.

Fixes: stolostron#481
Part of epic: submariner-io/enhancements#81

Signed-off-by: Janki Chhatbar <[email protected]>
Jaanki added a commit to Jaanki/submariner-addon that referenced this issue Sep 24, 2022
@Jaanki
Update submariner components to v0.14.0-m1
047ffcc 
to accommodate changes after operator-sdk upgrade.

1. api/submariner/v1alpha1 -> api/v1alpha1
2. pkg/client usage removed
3. other submariner projects are also updated.

Fixes: stolostron#481
Part of epic: submariner-io/enhancements#81

Signed-off-by: Janki Chhatbar <[email protected]>
@nyechiel
Copy link
Member

This should be done with #534

@nyechiel
Copy link
Member

/close

@openshift-ci openshift-ci bot closed this as completed Oct 30, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2022

@nyechiel: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jaanki Jaanki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update submariner-operator to v0.14.0-m1 Jaanki/submariner-addon
2 participants
@nyechiel @Jaanki