Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: Map allowed groups to applications #98

Open
luketainton opened this issue Jan 5, 2025 · 4 comments
Open

🚀 Feature: Map allowed groups to applications #98

luketainton opened this issue Jan 5, 2025 · 4 comments
Labels
feature New feature or request

Comments

@luketainton
Copy link

Feature description

Applications should have a list of allowed groups, i.e. groups of users that are allowed to use this application.

Pitch

This allows better control over which users can use which applications.

Example:
I'd like to be able to add a user to group "X" and then tell Pocket ID that for a user to be allowed access to an application, they must be in group "X". If the user signs into the app and they are in group "X" then it works as it does today. If they are not, Pocket ID should disallow authentication.

@luketainton luketainton added the feature New feature or request label Jan 5, 2025
@stonith404
Copy link
Owner

Isn't that something that the client should handle? For example Pingvin Share or Nextcloud allow you to specify which groups can access the service.

@simono41
Copy link

simono41 commented Jan 5, 2025

Isn't that something that the client should handle? For example Pingvin Share or Nextcloud allow you to specify which groups can access the service.

I also think, it could also be set at grafana that only certain groups have access to the dashboards.

But would be a cool feature if the pocket id could also regulate itself, e.g. such an exclude or include option which services can be used with the account and which cannot.

@luketainton
Copy link
Author

Isn't that something that the client should handle? For example Pingvin Share or Nextcloud allow you to specify which groups can access the service.

In an ideal world yes each client would handle this themselves, but unfortunately there are plenty of applications out there that don't. Some examples:

@stonith404
Copy link
Owner

Okay, I see.

While I personally wouldn’t use this feature and believe that handling group-based access is more appropriately managed by the client, I’ll keep an eye on the interest level. If this feature request gets more likes (👍), I’ll consider implementing it.

Of course I'm also open for a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants
@simono41 @luketainton @stonith404 and others