-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linter should enforce style in w3console #510
Comments
I dug into this a bit - it turns out that turning on our standard linter (eg, Many of the issues are easy to fix automatically, but many of them look like they are fairly tricky Preact-related typing issues. While we could invest time into fixing this, it doesn't seem especially "center of plate" for our team right now, especially since I'm already interested in moving us over to a more full-featured framework (see #419). Given this, I'd like to propose we solve this one of two ways:
|
I have no strong feeling on any of this. I would however propose another (perhaps) controversial solution to the problem. What if we just use prettier and and call it a day, it will address most issues and provide consistency without been nit picky on things that I personally hardly ever find useful. We could even setup https://github.com/marketplace/actions/prettier-action to just automate reformatting at PR level |
Ah so we actually were using prettier, but it didn't play nicely with eslint so I removed it: The other issue is that one of the main problems here is that All that being said I think this is probably a decision we should make after we have a larger conversation about how we want to roll w3up out to web3.storage and nft.storage users because the "right" move is going to be heavily dependent on our plans for that. |
It appears to be ignoring w3console at the moment, which means the code there is slowly drifting toward ugly - the mix of semicolon-terminated lines and non-semicolon-terminated lines is the most obvious smell but there are other issues as well.
As reported in #507 (comment)
The text was updated successfully, but these errors were encountered: