Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: re-enable vanilla and vue playwright tests and codesandbox #531

Open
travis opened this issue Jul 24, 2023 · 0 comments
Open

fix: re-enable vanilla and vue playwright tests and codesandbox #531

travis opened this issue Jul 24, 2023 · 0 comments

Comments

@travis
Copy link
Member

travis commented Jul 24, 2023

In #530 I've disabled playwright tests for Vue and our codesandbox builds:

  1. The Vue playwright tests are failing in test on something that seems like it should work, used to work, and works manually
  2. The "vanilla-JS" playwright tests have been failing and disabled for quite some time now
  3. The codesandbox builds seem to be failing because of a pnpm upgrade.

We should find time to get all of these working again, or break them out separately to fix.
@travis travis mentioned this issue Jul 24, 2023
Merged
travis added a commit that referenced this issue Jul 25, 2023
@travis
feat!: upgrade access client, ucanto and other packages (#530)
8e7321b 
We needed to upgrade the access client so that it will stop pointing at
`access.web3.storage` and that required ucanto upgrades.

Bumping the major version since I'm not sure this is backwards
compatible.

I've disabled the playwright tests for the vue examples for now because
they were failing in test but not when the example is run manually -
upgrading Vue might help but I'd like to do that in followup work.

I've also disabled codesandbox for now because it was failing, possibly
because of an unsupported pnpm version - I'm hoping this will simply go
away whenever codesandbox upgrades pnpm.

Filed #531 to track re-enabling tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@travis