Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling #flush will not flush the cache if using v1 of the API #27

Open
pfeiffer opened this issue Feb 17, 2022 · 0 comments
Open

Calling #flush will not flush the cache if using v1 of the API #27

pfeiffer opened this issue Feb 17, 2022 · 0 comments

Comments

@pfeiffer
Copy link
Contributor

Related to #17.

After the changes in #21, it seems that #flush is no longer flushing the cache, if the client is using the version 1 of the API.

client = Storyblok::Client.new(api_version: 1, ..)

client.flush # Will *not* flush cache

I think it that the caching and flushing should either be compatible with both v1 and v2 of the API or support should be dropped for specifying the API version if the behavior of the public interface of the gem cannot be kept the same between the two API versions.

@pfeiffer pfeiffer changed the title Calling #flush will not flush the cache, if using v1 of the API Calling #flush will not flush the cache if using v1 of the API Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant