-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What are differences to ros-drivers/openni2_camera? #7
Comments
@cdondrup yes, I made the wrapper before openni2 was officially a part of ROS. We had some STRANDS specific things in there for running 2 cameras at the same time, but that's no longer needed now. I also noticed a while ago that there was an official The biggest downside is that I've integrated But you're right, using the ROS |
That sounds reasonable. Do you have time to test this on your robot to see if and how it works? Linda is still not operational. |
Rosie is undergoing surgery at the moment - we're installing the 2nd PC and the new kinect. But I'll give the ROS |
Great. Thank you! |
@RaresAmbrus shall we close this? |
I still think we should use the default one. |
Having access to the low level driver allows us to do certain things like change the exposure or the whitebalancing, which we might want to experiment with in the future; it also allows us to apply certain correction functions (e.g. CLAMS or others) directly on the images coming out of the sensor. If at all we decide to do something along these lines, I don't know how easy it would be with the default openni2 package. @cdondrup I see now that I was supposed to look into the |
Indeed the oepnni2 seems to be stable. It does not have any functionalities I need in particular but if we ever need the skeleton tracker working, this would be an easy solution. |
Yes, consistent topic names and types sounds good, I can look into it. What about the skeleton tracker? Why would that work with the openni2 and not with ours, as long as we feed it with the proper topics? The data should be the same. |
Afaik, the tracker does not work on topics but directly on the hardware resource which is blocked when using our wrapper but still accessible when using openni2 |
@RaresAmbrus, if I'm not mistaken you implemented this wrapper before there was official ROS support for openni2. For a while now already there is the openni2_camera package. So my question is: Where are the differences between these two? Is there some STRANDS specific things in here? Could we just use the
openni2_camera
package instead?That would spare you some work and we wouldn't have to rely on our package for the camera drivers but could let everybody use the official one.
The text was updated successfully, but these errors were encountered: