Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for Image Branding #16

Open
Jailander opened this issue Oct 27, 2014 · 0 comments
Open

Improvements for Image Branding #16

Jailander opened this issue Oct 27, 2014 · 0 comments

Comments

@Jailander
Copy link
Member

In strands-project/strands_utils#112 some improvements were suggested by @cburbridge for this module, just reposting the suggestion here to close the issue on the strands_utils repository

"Sounds good. At the moment the code adds the rgb of the overlay to the RGB of the image:
output_image = input_image + 0.7 overlay. I was thinking maybe add an option to use the transparency channel of the PNG to allow overlaying as a replacement:
output_image = input_image if overlay is transparent else overlay
This way, it would be possible to overlay something on top of white backgrounds, and colours wont be diluted by the background.

Would it be better as a service rather than action? We could also add an option to process image streams continuously."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant