-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move € symbol to the left for de_* locales #1502
base: dev
Are you sure you want to change the base?
Conversation
I noticed the current rules here (http://publications.europa.eu/code/en/en-370303.htm) state:
However, Amazon.de has the euro symbol showing up after the amount. I'd really like there to be a consensus when I make changes like this, otherwise people will reach out and want the symbol on the OTHER SIDE again. I don't know how we should define consensus. It would be nice if we could outsource these decisions and piggy back on the decisions of a larger open source project like WooCommerce or even a non-WP project that deals with currencies. Any ideas? |
Nice job. I think we followed the same path (Quora > Wikipedia > European Union Commission). By the way, seems like the logic follows the old currency active before the euro introduction which is relatively new. At this point, I totally agree. Was out of knowledge about this, just thought it was a bug but it's not. Woocommerce should let the user choose where to put the currency symbol as far as I know; but really don't know how the multi-currency feature works. I'll check it out soon. I just found something very interesting.
By the way, code talking now. This pull request is just to follow the same code-style of what was already implemented into PMPro, but since there is no real solid logic in place, I think we should switch to something more solid first. Maybe we can just work on I'll make some other research. Speak soon. |
@ideadude Did we sort out a solution for this? |
All Submissions:
Changes proposed in this Pull Request:
Resolves #1473.
Other information: