Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Multisite Installations [Discussion] #33

Open
3 tasks done
andrewlimaza opened this issue Nov 18, 2021 · 0 comments
Open
3 tasks done

Support Multisite Installations [Discussion] #33

andrewlimaza opened this issue Nov 18, 2021 · 0 comments

Comments

@andrewlimaza
Copy link
Collaborator

Describe the bug
The custom roles created on the main site, shows up on the subsite. For example level 3 custom role on main site, shows on subsite which only has level 1 and 2. Should we have a filter to disable this or handle it better as there may be more conflicts when it comes to 'overlapping' membership ID's.

To Reproduce
Steps to reproduce the behavior:

  1. Install the Roles for Membership Add On individually on the main site and a subsite.
  2. Create more level's on the main site than on the subsite. (i.e. 3 levels on main site, 2 levels on subsite - or even just make sure there is no overlapping ID's between the sites for this test).
  3. Navigate to your subsite level settings and click edit, have a look at the role selector and notice roles from the main site showing up.

This is for sites that run PMPro individually on each site in the network (Do not use the Multisite Membership Add On for these tests).

Screenshots
Screen Shot 2021-11-18 at 15 38 36

In the above screenshot on the subsite, the "NEW!" (pmpro_role_2) level is on the main site and not the subsite.

Expected behavior
This needs more discussion, but should we isolate roles based on the site ID instead of registering the roles across all sites?

Isolating the problem (mark completed items with an [x]):

  • I have deactivated other plugins and confirmed this bug occurs when only Paid Memberships Pro plugin is active.
  • This bug happens with a default WordPress theme active, or Memberlite.
  • I can reproduce this bug consistently using the steps above.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant