-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Favicon instructions lead to TypeScript errors #1829
Comments
Moreover, I'd like to add that the favicon should be added from the UI as well as the other icons... |
Sam issue clean strapi (JS)
Follow the steps in the documentation https://docs.strapi.io/dev-docs/admin-panel-customization#favicon:
|
I had a similar issue. But it was solved here. // path: ./src/admin/webpack.config.js
'use strict';
const _ = require('lodash');
const path = require('path');
/* eslint-disable no-unused-vars */
module.exports = (config, webpack) => {
// this includes the folder ./src/admin/extensions with the alias assets
_.set(config, 'resolve.alias.assets', path.resolve(__dirname, './extensions'));
return config;
}; |
Thanks for reporting, we'll reference this in docs soon. Re-opening the issue to ensure it's not missed. |
Link to the documentation page or resource
https://docs.strapi.io/dev-docs/admin-panel-customization#favicon
Describe the bug
The instructions about adding a favicon have errors, and it doesn't work when you copy and paste it in a new project.
This is the error that appears:
Additional context
This is the code:
Suggested improvements or fixes
Although it is a typical TS problem solvable by the developer, but documentation code shouldn't have errors. Nowhere in strapi's documentation, it is explained how to deal with this.
Related issue(s)/PR(s)
#1000
The text was updated successfully, but these errors were encountered: