From 87d164865b71ce7e2cb4bea3563c3160c38f9815 Mon Sep 17 00:00:00 2001
From: Adrian Perez <adrian@adrianperez.org>
Date: Thu, 23 May 2024 15:07:41 -0700
Subject: [PATCH] fix(dual-output): global rescale output causes stretched
 stream on vertical (#5008)

* fix(dual-output): global rescale output causes stretched stream on vertical

* fix: refresh video settings instead of destroy ctx
---
 app/services/dual-output/dual-output.ts | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/app/services/dual-output/dual-output.ts b/app/services/dual-output/dual-output.ts
index dea9290b11eb..567cd688fd60 100644
--- a/app/services/dual-output/dual-output.ts
+++ b/app/services/dual-output/dual-output.ts
@@ -343,6 +343,9 @@ export class DualOutputService extends PersistentStatefulService<IDualOutputServ
     // confirm custom destinations have a default display
     this.confirmDestinationDisplays();
 
+    // Disable global Rescale Output
+    this.disableGlobalRescaleIfNeeded();
+
     /**
      * Ensures that the scene nodes are assigned a context
      */
@@ -377,6 +380,7 @@ export class DualOutputService extends PersistentStatefulService<IDualOutputServ
     this.SET_SHOW_DUAL_OUTPUT(status);
 
     if (this.state.dualOutputMode) {
+      this.disableGlobalRescaleIfNeeded();
       this.confirmOrCreateVerticalNodes(this.views.activeSceneId);
 
       /**
@@ -413,6 +417,25 @@ export class DualOutputService extends PersistentStatefulService<IDualOutputServ
       }
     }
   }
+  disableGlobalRescaleIfNeeded() {
+    // TODO: this could be improved, either by state tracking or making it compatible with dual output
+    // For now, disable global Rescale Output under Streaming if dual output is enabled
+    if (this.state.dualOutputMode) {
+      const output = this.settingsService.state.Output.formData;
+      const globalRescaleOutput = this.settingsService.findSettingValue(
+        output,
+        'Streaming',
+        'Rescale',
+      );
+      if (globalRescaleOutput) {
+        // `Output` not a typo, it is different from above
+        this.settingsService.setSettingValue('Output', 'Rescale', false);
+        // TODO: find a cleaner way to make dual output recalculate its settings for the vertical display
+        // since even after disabling "rescale output" its settings persists, and looks stretched.
+        this.settingsService.refreshVideoSettings();
+      }
+    }
+  }
 
   convertSceneSources(sceneId: string) {
     const sceneSources = this.scenesService.views.sceneSourcesForScene(sceneId);