Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create common super-interface for containers #34

Open
see-quick opened this issue Mar 25, 2022 · 0 comments
Open

Create common super-interface for containers #34

see-quick opened this issue Mar 25, 2022 · 0 comments

Comments

@see-quick
Copy link
Member

As discussed strimzi/strimzi-kafka-operator#6400, we should create a common super-interface for StrimziKafkaCluster and StrimziKafkaContainer to allow precisely this kind of abstraction in users. The reason why we need it is that currently, we can't use super-type of StrimziKafkaContainer, StrimziZooKeeperContainer...and the only supertype is Startable. This interface should expose getBootstrapServers() and getZookeeperConnectString() to the users.

✅ It would also be more typesafe, since trying to call this method with any old Startable would then be a compile-time error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant