Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community contributions to keep mantaining deprecated current context feature #2728

Closed
josieusa opened this issue Sep 7, 2016 · 3 comments
Closed
Assignees

Comments

@josieusa
Copy link

josieusa commented Sep 7, 2016

As suggested by @bajtos in issue 1495 I'm opening a new issue for discussing the solutions which are not alternative to the deprecated current context feature; that is, solutions that try to fix or help with current context issues (e.g. lost context) and not to replace the current context feature with a similar one; for the latter kind of solutions (alternatives), please keep using issue 1495. Even if the approaches we are going to discuss here will be unofficial, I think that many people have an existing app that they don't want to refactor too heavily in order to address these issues, and therefore may be interested in trying this approach.

This is my attempt to fix it. Please read its README before trying it, because it includes a lot of info.
loopback-context PR #2
Important, I don't use it alone; I'm using it in combination with the npm shrinkwrapapproach suggested in issue 1495 which is not perfect because it has the downside that you must be "lucky" to not get a broken install (seemingly) randomly, and it's not easy to notice at all. But once I got a working install, it's been all fine so far. Don't take this as an expert advice, it's just my own experience with it.

I didn't call my pull request production-ready because tests are not published, but I have some high quality tests, so its quality is better than average.
Maybe I'm going to gradually try it in production soon, but until then, I don't take the responsibility to recommend using it in production to anyone yet. OBSOLETE PR

Any Loopback users interested in further discussion of these kinds of approaches to the context issues?
Thank you

@josieusa
Copy link
Author

josieusa commented Sep 9, 2016

Just wanted to add loopback-context PR #11

@bajtos bajtos removed the bug label Sep 13, 2016
@josieusa
Copy link
Author

josieusa commented Dec 20, 2016

To people watching the issue #1495 I'd like to inform that the loopback-context PR 11 is no longer a work-in-progress. It works for me. For details see the PR 11.

@bajtos bajtos self-assigned this Dec 20, 2016
@bajtos
Copy link
Member

bajtos commented Jan 9, 2017

strongloop/loopback-context#11 has been landed and a new version [email protected] has been released.

I am closing this issue as done. Please open a new issue in loopback-context project if there is anything else remaining to discuss.

@bajtos bajtos closed this as completed Jan 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants