Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email/password change should not invalidate current session #3034

Closed
bajtos opened this issue Dec 16, 2016 · 1 comment
Closed

Email/password change should not invalidate current session #3034

bajtos opened this issue Dec 16, 2016 · 1 comment
Assignees
Milestone

Comments

@bajtos
Copy link
Member

bajtos commented Dec 16, 2016

In #2693 and #3021, we implemented access-token invalidation when the users changes an email or a password. However, the current code deletes all access tokens, including the token used to make the change password/email request.

IMO, this is a poor user experience, the access token (session) used to make the change should be preserved.

One of the reasons why this was not made in the original pull requests, is that we don't have a good solution for getting the current access token. The easiest way forward is to wait for #3023 to land, after which we can use ctx.options.accessToken to exclude the current access token from the delete query.

@bajtos
Copy link
Member Author

bajtos commented Jan 25, 2017

Done.

@bajtos bajtos closed this as completed Jan 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants