Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated configure macros #356

Open
fancycode opened this issue Oct 25, 2022 · 7 comments
Open

Deprecated configure macros #356

fancycode opened this issue Oct 25, 2022 · 7 comments

Comments

@fancycode
Copy link
Member

Building on Debian sid complains about various deprecated macros in configure.ac:

libtoolize: putting auxiliary files in '.'.
libtoolize: copying file './ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
libtoolize: copying file 'm4/libtool.m4'
libtoolize: copying file 'm4/ltoptions.m4'
libtoolize: copying file 'm4/ltsugar.m4'
libtoolize: copying file 'm4/ltversion.m4'
libtoolize: copying file 'm4/lt~obsolete.m4'
configure.ac:24: warning: The macro `AC_CANONICAL_SYSTEM' is obsolete.
configure.ac:24: You should run autoupdate.
./lib/autoconf/general.m4:2081: AC_CANONICAL_SYSTEM is expanded from...
configure.ac:24: the top level
configure.ac:59: warning: The macro `AC_TRY_COMPILE' is obsolete.
configure.ac:59: You should run autoupdate.
./lib/autoconf/general.m4:2847: AC_TRY_COMPILE is expanded from...
lib/m4sugar/m4sh.m4:692: _AS_IF_ELSE is expanded from...
lib/m4sugar/m4sh.m4:699: AS_IF is expanded from...
./lib/autoconf/general.m4:2249: AC_CACHE_VAL is expanded from...
m4/visibility.m4:23: gl_VISIBILITY is expanded from...
configure.ac:59: the top level
configure.ac:110: warning: The macro `AC_TRY_COMPILE' is obsolete.
configure.ac:110: You should run autoupdate.
./lib/autoconf/general.m4:2847: AC_TRY_COMPILE is expanded from...
configure.ac:110: the top level
configure.ac:123: warning: The macro `AC_TRY_COMPILE' is obsolete.
configure.ac:123: You should run autoupdate.
./lib/autoconf/general.m4:2847: AC_TRY_COMPILE is expanded from...
configure.ac:123: the top level
configure.ac:132: warning: The macro `AC_TRY_COMPILE' is obsolete.
configure.ac:132: You should run autoupdate.
./lib/autoconf/general.m4:2847: AC_TRY_COMPILE is expanded from...
configure.ac:132: the top level
configure.ac:148: warning: The macro `AC_TRY_COMPILE' is obsolete.
configure.ac:148: You should run autoupdate.
./lib/autoconf/general.m4:2847: AC_TRY_COMPILE is expanded from...
configure.ac:148: the top level
configure.ac:166: warning: The macro `AC_TRY_COMPILE' is obsolete.
configure.ac:166: You should run autoupdate.
./lib/autoconf/general.m4:2847: AC_TRY_COMPILE is expanded from...
configure.ac:166: the top level
configure.ac:31: installing './compile'
configure.ac:43: installing './missing'
@farindk
Copy link
Contributor

farindk commented Sep 19, 2023

Do we still need the configure script or can we switch to cmake as the only build environment?

@farindk
Copy link
Contributor

farindk commented Nov 20, 2023

@fancycode Any opinion on this?

@farindk
Copy link
Contributor

farindk commented Nov 20, 2023

The CI still uses the configure scripts.

@farindk
Copy link
Contributor

farindk commented Jan 8, 2024

TODO:

  • use cmake in CI scripts
  • add sherlock265 to cmake
  • compile Neon code for ARM architectures

@brad0
Copy link

brad0 commented Mar 8, 2024

Looking at switching to CMake from autoconf I noticed the list of installed tools has a bunch of missing stuff..

@@ -1,12 +1,3 @@
 @conflict libde265-1.0.5
-@bin bin/acceleration_speed
-@bin bin/bjoentegaard
-@bin bin/block-rate-estim
 @bin bin/dec265
-@bin bin/enc265
-@bin bin/gen-enc-table
-@bin bin/hdrcopy
-@bin bin/rd-curves
-@bin bin/sherlock265
 @comment @bin bin/tests
-@bin bin/yuv-distortion

@farindk
Copy link
Contributor

farindk commented Mar 8, 2024

This is mostly ok. Most of those were small test programs for development. For some I even forgot what they do.

The only thing that might be some fun to look at is sherlock265. The other ones should either be dropped completely or hidden behind a default-off flag.

@brad0
Copy link

brad0 commented Mar 8, 2024

Ok, I noticed sherlock265 was mentioned. I figured I'd mention the rest incase they were useful at all. I have no idea what some of those do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants