Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the destructor of decoder_context include more cleanups? #461

Open
farindk opened this issue Jun 11, 2024 · 0 comments
Open

Should the destructor of decoder_context include more cleanups? #461

farindk opened this issue Jun 11, 2024 · 0 comments

Comments

@farindk
Copy link
Contributor

farindk commented Jun 11, 2024

Copied from: strukturag/libheif#1166 (comment)


Inside the reset method of the decoder_context the following is done:

  dpb.clear();

  nal_parser.remove_pending_input_data();

Should this not also be done inside the destructor of decoder_context? We are getting an oss-fuzz error report about memory leaks of NAL_unit in the oss-fuzz tooling of @ImageMagick and it looks like it is happening because of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant