-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub reporter #168
Comments
This is something I think would fit better as a feature of the dashboard, where you can configure the dashboard to post the result to github as a status check. That way we only have to implement it once, and adds an extra use case for using the dashboard. This is also how other services like sonarcloud work. |
As @Mobrockers points out, if submitting the check instead is a responsibility of the dashboard, then you can avoid having one GitHub API client to this in stryker4s, and another one in stryker-net and so on. There are a couple of other things to put on the wish list here: reporting changes in score between builds/checks is a major one. Features like that (tracking reports by commit rather then by branch) also fit much better in the dashboard project. |
I agree it does make more sense for this functionality to be in the Stryker dashboard. I'll move this issue there and edit the description |
For anyone interested in this, I have made a Github Action that creates annotations from a Stryker report. |
@johanholmerin our json schema is actually not Stryker specific :) We design and publish the schema but iirc other mutation testing tools also implement this schema. So your action is useful not only to Stryker users but also other mutation testing tool users! |
I did not know that. I've changed the name to make it clearer that it's not specific to Stryker |
Do we still want this functionality in the Stryker dashboard? Or does the action mentioned above provide the functionality that was wanted originally? |
At some point I would like to see this integrated into the dashboard similar to for example sonarqube. |
GitHub has something called 'check-runs' they allow adding annotations to a 'check'. Checks are for example what GitHub Actions create. These annotations show up at a line of code. A good example is the eslint-action which lints code and displays error messages directly in GitHub. More info about checks can be found here or here. Annotations can be added to a new check created by the action, or an existing one that is currently running like the CI action. It looks a little like this:
We could add something similar to the Stryker Dashboard by adding a GitHub reporter. This reporter could annotate survived mutants at their position in the source code on GitHub so people can view their mutation testing results in GitHub. This would also work very well in combination with a diff-runner (not supported yet by Stryker4s). A score could also be reported at the end
Some things that need discussion:
The text was updated successfully, but these errors were encountered: