Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testing disable comment plugins by using ignoreDisables #36

Open
DMartens opened this issue Jun 28, 2021 · 1 comment
Open

Fix testing disable comment plugins by using ignoreDisables #36

DMartens opened this issue Jun 28, 2021 · 1 comment
Labels
status: ask to implement ask before implementing as may no longer be relevant type: bug a problem with a feature or rule

Comments

@DMartens
Copy link

DMartens commented Jun 28, 2021

What is the problem you're trying to solve?

I am currently writing a plugin for disable comments.

The problem are disable comments like /* stylelint disable */ as they disable all rules.
As such they also disable the rule I try to test.

What solution would you like to see?

I saw #26 which would solve the issue partially but for some reason that PR is not merged.
Personally I would prefer directly passing the config to getTestRule like the options so they are shared between the rules.

Another way to solve this is to always set ignoreDisables to true as no rule author should test whether the disables work.

@jeddy3 jeddy3 changed the title Allow passing stylelintConfig Use ignoreDisables Jul 2, 2021
@jeddy3
Copy link
Member

jeddy3 commented Jul 2, 2021

Another way to solve this is to always set ignoreDisables to true as no rule author should test whether the disables work.

This sounds viable to me. I'll label as discussion in case anyone else has thoughts.

@jeddy3 jeddy3 added the status: needs discussion triage needs further discussion label Jul 2, 2021
@jeddy3 jeddy3 changed the title Use ignoreDisables Fix testing disable comment plugins by using ignoreDisables Feb 16, 2023
@jeddy3 jeddy3 added status: ask to implement ask before implementing as may no longer be relevant type: bug a problem with a feature or rule and removed status: needs discussion triage needs further discussion labels Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ask to implement ask before implementing as may no longer be relevant type: bug a problem with a feature or rule
Projects
None yet
Development

No branches or pull requests

2 participants