This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Implement 'likes' #1106
Merged
Implement 'likes' #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfollington
force-pushed
the
2024-02-07-user-likes
branch
2 times, most recently
from
918c5c0
to
dfd4d58
Compare
bfollington
force-pushed
the
2024-02-07-user-likes
branch
from
34fca27
to
5d304f2
Compare
gordonbrander
approved these changes
Feb 13, 2024
xcode/Subconscious/Shared/Components/Detail/MemoViewerDetailMetaSheetView.swift
Outdated
Show resolved
Hide resolved
xcode/Subconscious/Shared/Components/Detail/MemoViewerDetailMetaSheetView.swift
Outdated
Show resolved
Hide resolved
bfollington
force-pushed
the
2024-02-07-user-likes
branch
from
f5a1af2
to
d980fc1
Compare
bfollington
added a commit
that referenced
this pull request
Feb 14, 2024
Follow on from #1106 Introduces: - Show liked status with a small heart in list views (notebook & profile) - Add / remove likes from the list view context menu - A new `EntryNotification` abstraction to encode the core set of actions that can be taken on a note # Demo https://github.com/subconsciousnetwork/subconscious/assets/5009316/b4cc4bda-049f-4f62-9dcb-ae4ab8858be2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_likes_.jsonUserLikesServiceThere is obvious room for improvement by incorporating likes into the DB index (#1111) and, as an extension, building content discovery (via likes-of-friends). There may also be performance issues associated with loading previews for a large number of likes.
We have also discussed changing the way we handle hidden files (#1112), which affects this feature.
Questions
Demo
Screen.Recording.2024-02-12.at.4.53.23.pm.mov