New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shfmt automation #1737

Open

dfarrell07 opened this issue Oct 10, 2024 · 1 comment

Member

dfarrell07 commented Oct 10, 2024

Per a discussion during code review...

Nit: Should there be indentation inside this loop?

Which highlights that [shellcheck doesn't do format checking](https://github.com/koalaman/shellcheck/issues/2463). They recommend [shfmt](https://github.com/mvdan/sh). I can look into it if other people think it would be helpful.

Originally posted by @dfarrell07 in #1730 (comment)

The text was updated successfully, but these errors were encountered:

dfarrell07 mentioned this issue

Check unmerged commits in dependencies #1730

Merged

Member Author

dfarrell07 commented Oct 22, 2024

There's a GHA that combines shfmt and shellcheck (and another tool): https://github.com/marketplace/actions/sh-checker

Trade-off is that we'd lose the ability to run it locally, which I think is important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment