Check deployed images against newly-built images #1265
Conversation
skitt
requested review from
mkolesnik,
Oats87,
sridhargaddam and
tpantelis
as code owners
|
🤖 Created branch: z_pr1265/skitt/check-deployed-image |
| done | ||
| done | ||
| if [ "$image_mismatch" = true ]; then | ||
| kubectl get pods -A -o json |
There was a problem hiding this comment.
This is too verbose and will be simplified before the patch is submitted for final review.
There was a problem hiding this comment.
Does this still need tweaking?
There was a problem hiding this comment.
Yes I see it in the logs now, very verbose https://github.com/submariner-io/shipyard/actions/runs/5389288771/jobs/9783083207?pr=1265#step:6:3131
To ensure that we're testing with the latest image, as available in the local repository, we need to override all users of the nettest image. Currently subctl exposes two components for that: submariner-nettest and submariner-metrics-proxy. This patch adds support for multiple components per image; since the project already preloads the nettest image, this results in the correct image override arguments being given to subctl. Signed-off-by: Stephen Kitt <[email protected]>
After deployment, if any images were built, check that they were used in the deployment. Signed-off-by: Stephen Kitt <[email protected]>
skitt
force-pushed
the
check-deployed-image
branch
from
582ee2c to
ec9cc48
Compare
|
Looks like all the Helm jobs are failing |
| fi | ||
| done | ||
| done | ||
| if [ "$image_mismatch" = true ]; then |
There was a problem hiding this comment.
This should be run when opted-in, since you might want to deploy with various images when deploying locally or when we're doing upgrade testing
|
Is this still relevant? |
|
Yes; it needs improved logging on errors, and a way of disabling the test (as Mike says, and for the Helm charts; there’s probably stuff to fix in the Helm chart builds but that can be done separately). |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further |
|
🤖 Closed branches: [z_pr1265/skitt/check-deployed-image] |
See individual commits for details.
This still needs fixes in Helm deployments and an opt-out for upgrade tests.
Fixes: #479.