Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use future block height in historical state query #1124

Open
ianhe8x opened this issue Jun 25, 2022 · 1 comment · May be fixed by #1193
Open

Use future block height in historical state query #1124

ianhe8x opened this issue Jun 25, 2022 · 1 comment · May be fixed by #1193
Labels
bug Something isn't working

Comments

@ianhe8x
Copy link
Collaborator

ianhe8x commented Jun 25, 2022

Precondition

  • historical enabled
  • use blockHeight in the query

When specify a future blockHeight (comparing with lastProcessedHeight)
Currently it returns results same as blockHeight is not specified, this might lead to some confusion. Maybe a better way is throw error in this case.
@ianhe8x ianhe8x changed the title Pass future block height in historical state query Use future block height in historical state query Jun 25, 2022
@spitko spitko linked a pull request Jul 17, 2022 that will close this issue
Open
11 tasks
@stwiname stwiname added the bug Something isn't working label Jul 18, 2022
@jamesbayly
Copy link
Contributor

jamesbayly commented Nov 6, 2022 •
edited
Loading

I think the current behaviour is fine from my pov. If the requested block height is not available, then you receive the next block height descending

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validate blockHeight argument spitko/subql
3 participants
@stwiname @ianhe8x @jamesbayly