Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding setup.py #7

Open
vibhatha opened this issue Nov 10, 2022 · 2 comments
Open

Adding setup.py #7

vibhatha opened this issue Nov 10, 2022 · 2 comments

Comments

@vibhatha
Copy link
Contributor

Hello community,

I am working on an integration test for Arrow, based on the test queries on this repository. The idea is to check Arrow PRs against the test cases built here. The draft PR is almost in a workable state except for packaging requirements in consumer-testing. Do you think it is a wise idea to include a setup.py for this project? The advantage is, it would smooth the usage with other platforms and workflows.

Value added: maybe we can also include entrypoints for a CLI application to run the test cases or benchmarks (future) quite easily.

Something like,

consumer-testing test --platform arrow --module tpch
consumer-testing benchmark --platform arrow --module tpch --publish <url>

We could use click library to do this. This is merely an extension to setup.py

cc @jacques-n @richtia appreciate your feedback.

@westonpace
Copy link
Member

One challenge that we might encounter is that, right now, substrait-io/consumer-testing contains a bunch of tests. Would these test cases be packaged up as part of the distribution? Does pytest support something like that? Would it be possible for me to import tests from a remote package?

@vibhatha
Copy link
Contributor Author

I am not entirely sure about that, my personal experience is I don't package tests with the core library. It just floats outside. Please correct me if there is a better approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants