From 84481476d71423e61e1d4418b56a741929d1bbd0 Mon Sep 17 00:00:00 2001 From: Dalia Shaaban <144673861+dshaaban01@users.noreply.github.com> Date: Mon, 13 Jan 2025 09:39:14 +0100 Subject: [PATCH] chore: random comment clean up (#44) --- include/substrait-mlir/Dialect/Substrait/IR/CMakeLists.txt | 2 +- lib/Target/SubstraitPB/Export.cpp | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/include/substrait-mlir/Dialect/Substrait/IR/CMakeLists.txt b/include/substrait-mlir/Dialect/Substrait/IR/CMakeLists.txt index bb01665..7a3a84a 100644 --- a/include/substrait-mlir/Dialect/Substrait/IR/CMakeLists.txt +++ b/include/substrait-mlir/Dialect/Substrait/IR/CMakeLists.txt @@ -1,7 +1,7 @@ add_mlir_dialect(SubstraitOps substrait) add_dependencies(MLIRSubstraitDialect MLIRSubstraitOpsIncGen) -# Add SetOpKind attribute +# Add Enums set(LLVM_TARGET_DEFINITIONS SubstraitOps.td) mlir_tablegen(SubstraitEnums.h.inc -gen-enum-decls) mlir_tablegen(SubstraitEnums.cpp.inc -gen-enum-defs) diff --git a/lib/Target/SubstraitPB/Export.cpp b/lib/Target/SubstraitPB/Export.cpp index e85e20e..010eca3 100644 --- a/lib/Target/SubstraitPB/Export.cpp +++ b/lib/Target/SubstraitPB/Export.cpp @@ -195,6 +195,7 @@ SubstraitExporter::exportType(Location loc, mlir::Type mlirType) { return std::move(type); } + // Handle tuple types. if (auto tupleType = llvm::dyn_cast(mlirType)) { auto structType = std::make_unique(); for (mlir::Type fieldType : tupleType.getTypes()) {