Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: random comment clean up #44

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

dshaaban01
Copy link
Contributor

Random minor clean up in this PR to do with comments:

  1. Fix incorrect comment to correct comment
  2. Add a helpful comment to show we are handling tuple case

Copy link
Collaborator

@ingomueller-net ingomueller-net left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks!

@dshaaban01 dshaaban01 force-pushed the dalia/fixes/comments branch from bb3a5ca to e345893 Compare January 6, 2025 20:11
@dshaaban01
Copy link
Contributor Author

Done.

@dshaaban01
Copy link
Contributor Author

I think this can be easy merged :)

@ingomueller-net ingomueller-net merged commit 8448147 into substrait-io:main Jan 13, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants