Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for parse module #157

Open
6 of 32 tasks
mbrobbel opened this issue Mar 5, 2024 · 4 comments
Open
6 of 32 tasks

Tracking issue for parse module #157

mbrobbel opened this issue Mar 5, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@mbrobbel
Copy link
Member

mbrobbel commented Mar 5, 2024

This is a tracking issue for a parse module in the Substrait crate.

Some requirements of Substrait can not be expressed via Protobuf definition or schema files. A parse module can provide types for the generated types, that when constructed are known to be checked. This enables producers and consumers to skip redundant checking of invariants described by the specification.

I want to propose incrementally building the parse module i.e. split up the intial work in #89 to help reviewers and to encourage collaboration.

Parser progress

Proto

Text

Other tasks

@mbrobbel mbrobbel mentioned this issue Mar 7, 2024
10 tasks
@mbrobbel mbrobbel self-assigned this Mar 19, 2024
@mbrobbel mbrobbel pinned this issue Mar 19, 2024
@mbrobbel mbrobbel added enhancement New feature or request help wanted Extra attention is needed labels Mar 19, 2024
@holicc
Copy link

holicc commented Apr 9, 2024

Any plans to support parsing SQL directly?

@mbrobbel
Copy link
Member Author

mbrobbel commented Apr 9, 2024

Any plans to support parsing SQL directly?

Absolutely. I think a logical next step would be to add builders for the parsed types, which could be used to build a SQL to substrait tool.

@holicc
Copy link

holicc commented Apr 9, 2024

Any plans to support parsing SQL directly?

Absolutely. I think a logical next step would be to add builders for the parsed types, which could be used to build a SQL to substrait tool.

Cool! I'm interested in this. Anything I can do?

@mbrobbel
Copy link
Member Author

mbrobbel commented Apr 9, 2024

Any plans to support parsing SQL directly?

Absolutely. I think a logical next step would be to add builders for the parsed types, which could be used to build a SQL to substrait tool.

Cool! I'm interested in this. Anything I can do?

If you want to contribute: this task would be a good one. Or else figuring out an ergonomic design for the builders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants