Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement validation for simple extensions #3

Open
jvanstraten opened this issue May 30, 2022 · 1 comment
Open

Implement validation for simple extensions #3

jvanstraten opened this issue May 30, 2022 · 1 comment

Comments

@jvanstraten
Copy link
Collaborator

Everything related to the semantics of simple extensions currently just throws warnings. Only the schema for the YAML files is already validated.

Note that the largest/most important bit of logic that's needed is a type expression parser. The rest should be comparatively straightforward.

@jvanstraten jvanstraten self-assigned this May 30, 2022
@jvanstraten
Copy link
Collaborator Author

Just to update on this for posterity: as of validator 0.0.9 the type expression system proposed in substrait-io/substrait#352 is currently implemented in the validator, though it is not really used by anything yet (extension parsing is still missing for the most part) and has not been thoroughly tested. With that PR immediately derailing for procedural and personal reasons, I'm back to square one of not knowing how to correctly implement these things, and have ceased my involvement with the project a lot more abruptly than I was intending to. Hopefully my code will be useful later on nonetheless, if only for inspiration, but if not, it should just be removed.

@jvanstraten jvanstraten removed their assignment Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant