Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rank too long (legendary grandmaster) breaks the card. #43

Open
sudiptob2 opened this issue Aug 24, 2022 · 6 comments
Open

Rank too long (legendary grandmaster) breaks the card. #43

sudiptob2 opened this issue Aug 24, 2022 · 6 comments
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest hacktoberfest-accepted hactoberfest2022 help wanted Extra attention is needed

Comments

@sudiptob2
Copy link
Owner

Long rank such as legendary grandmaster breaks the card 🤔
I hope a legendary grandmaster will fix this bug 🙏
image

@sudiptob2 sudiptob2 added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Aug 24, 2022
@iamrubayet
Copy link

if we increase the fixed size will this solve the bug ?

@iamrubayet
Copy link

or we can use slice like we use in long user name ?

@sudiptob2
Copy link
Owner Author

I don't want to change the card size; it's pretty standard. On the other hand, slicing will not solve the problem because rank is like a designation of a codeforces user. If we slice legendary grandmaster it will become grandmaster which is something totally different.

I think we can use Acronym.acronimize() take the acronym of the rank if the length of rank exceeds some predefined length.
In this case, the legendary grandmaster will be converted into LG.

@sudiptob2 sudiptob2 added hacktoberfest-accepted hactoberfest2022 hacktoberfest and removed hacktoberfest-accepted hactoberfest2022 enhancement New feature or request labels Oct 3, 2022
@Ria-R
Copy link

Ria-R commented Oct 18, 2022

Hello, can I be assigned this issue?

@TOMWT-qwq
Copy link

Not only lgm is too long. This issue is not completely solved.

@sudiptob2
Copy link
Owner Author

@TOMWT-qwq I think now it's time to solve this issue 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest hacktoberfest-accepted hactoberfest2022 help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants