Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with IDEA 2021.2.x #1

Open
MarioAriasC opened this issue Sep 30, 2021 · 3 comments · May be fixed by #2
Open

Compatibility with IDEA 2021.2.x #1

MarioAriasC opened this issue Sep 30, 2021 · 3 comments · May be fixed by #2

Comments

@MarioAriasC
Copy link

Hi,

Can you make it compatible with the latest IDEA version, please?

Do you need any help? Is this project still active?

Thanks.
jonppe pushed a commit to jonppe/intellij-zig that referenced this issue Nov 10, 2021
Do not set pluginUntilBuild to allow using with future releases
ca8b140 
This should allow using the same plugin with future IntelliJ releases
and fix sudison#1.

Briefly looking e.g. discussion at https://intellij-support.jetbrains.com/hc/en-us/community/posts/360010590059-Why-pluginUntilBuild-is-mandatory
it seems that this is acceptable approach but validity
against future releases should be checked using intellij-plugin-verifier.

As of writing, the current latest version number is 202 matching
JetBrains products 2021.2.*.

The output of the intellij-plugin-verifier says this plugin is still compatible:

  2021-11-10T21:03:56 [main] INFO  verification - Finished 1 of 1 verifications (in 2.6 s): IU-212.5457.46 against org.zig:0.3.1: Compatible. 3 usages of deprecated API. 1 usage of internal API
  Plugin org.zig:0.3.1 against IU-212.5457.46: Compatible. 3 usages of deprecated API. 1 usage of internal API
  Deprecated API usages (3):
    \#Deprecated method com.intellij.openapi.util.IconLoader.getIcon(String) invocation
        Deprecated method com.intellij.openapi.util.IconLoader.getIcon(java.lang.String path) : javax.swing.Icon is invoked in org.zig.ZigIcons.<clinit>() : void
    \#Deprecated method com.intellij.openapi.project.Project.getBaseDir() invocation
        Deprecated method com.intellij.openapi.project.Project.getBaseDir() : com.intellij.openapi.vfs.VirtualFile is invoked in org.zig.runner.ZigCompilerOutputFilter.applyFilter(String, int) : Filter.Result
    \#Deprecated method com.intellij.lang.ParserDefinition.spaceExistanceTypeBetweenTokens(ASTNode, ASTNode) is overridden
        Deprecated method com.intellij.lang.ParserDefinition.spaceExistanceTypeBetweenTokens(com.intellij.lang.ASTNode left, com.intellij.lang.ASTNode right) : com.intellij.lang.ParserDefinition.SpaceRequirements is overridden in class org.zig.ZigParserDefinition
  Internal API usages (1):
    \#Internal method com.intellij.execution.ExecutionManager.startRunProfile(ExecutionEnvironment, Function0) invocation
        Internal method com.intellij.execution.ExecutionManager.startRunProfile(com.intellij.execution.runners.ExecutionEnvironment arg0, kotlin.jvm.functions.Function0 arg1) : void is invoked in org.zig.runner.ZigRunner.execute(ExecutionEnvironment) : void. This method is marked with @org.jetbrains.annotations.ApiStatus.Internal annotation and indicates that the method is not supposed to be used in client code.
    Plugin can be loaded/unloaded without IDE restart
@jonppe jonppe linked a pull request Nov 10, 2021 that will close this issue
Open
@jonppe
Copy link

jonppe commented Nov 10, 2021

If someone is in a hurry to try this plugin with latest JetBrains editors, you can checkout the related PR and then run:

./gradlew
./gradlew build

and the plugin should appear under folder build/distributions/

@MarioAriasC
Copy link
Author

MarioAriasC commented Nov 11, 2021 •
edited
Loading

I'm working on my own version; I'll release it in the next couple of weeks.

It has a better rendering lexer and it covers more language cases.

@MarioAriasC
Copy link
Author

This is my version, It isn't a fork itself, but I used a lot of code from the codebase https://github.com/MarioAriasC/zig-support

In a couple of days, it'll be ready for download on the plugins website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not set pluginUntilBuild to allow using with future releases jonppe/intellij-zig
2 participants
@MarioAriasC @jonppe