Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making put_param public #153

Open
tmcnitt opened this issue Jul 9, 2021 · 1 comment · May be fixed by #154
Open

Making put_param public #153

tmcnitt opened this issue Jul 9, 2021 · 1 comment · May be fixed by #154

Comments

@tmcnitt
Copy link

tmcnitt commented Jul 9, 2021

When creating a block, all the exposed solutions require the data to be inputted at once. However, there is a function put_param that is able to upsert data to columns. It's used for the Vec RowBuilder Impl. This would be handy to have exposed for custom RowBuilder implementations. Is there any reason it is not? I can open PR to make public
@suharev7
Copy link
Owner

I didn't want that put_param to be public because it allows making invalid blocks with a non-equals length of columns. But, I think we can add doc comments that it's unrecommended by calling directly, and it's only for custom RowBuilder implementations. And of course, I would be happy to accept your PR. And perhaps it should have a more describable name if it is to be public.

@tmcnitt tmcnitt linked a pull request Jul 16, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add push_value method to Block tmcnitt/clickhouse-rs
2 participants
@suharev7 @tmcnitt