Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsound usages of unsafe implementation from u8 to $t #223

Open
llooFlashooll opened this issue Aug 20, 2024 · 0 comments
Open

Unsound usages of unsafe implementation from u8 to $t #223

llooFlashooll opened this issue Aug 20, 2024 · 0 comments

Comments

@llooFlashooll
Copy link

llooFlashooll commented Aug 20, 2024

Title: Unsound usages of unsafe implementation from u8 to $t

Hi, I am scanning the clickhouse-srv in the latest version with my own static analyzer tool.

Unsafe conversion found at: src/types/column/iter/mod.rs#L60

   unsafe {
      let mut ptr: *const u8 = ptr::null();
      let mut size: usize = 0;
      column.get_internal(&[&mut ptr, &mut size as *mut usize as *mut *const u8], 0)?;
      assert_ne!(ptr, ptr::null());
      Ok(slice::from_raw_parts(ptr as *const $t, size).iter())
   }

This unsound implementation would create a misalignment issues if the type size of u8 is smaller than the type size of $t.

This would potentially cause undefined behaviors in Rust. If we further manipulate the problematic converted types, it would potentially lead to different consequences such as access out-of-bound. I am reporting this issue for your attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant