Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 Support #34

Open
reformed opened this issue Mar 7, 2023 · 0 comments
Open

PHP 8 Support #34

reformed opened this issue Mar 7, 2023 · 0 comments

Comments

@reformed
Copy link

reformed commented Mar 7, 2023

This library is causing a deprecation notice:

Deprecated: Return type of Suin\RSSWriter\SimpleXMLElement::addChild($name, $value = null, $namespace = null) should either be compatible with SimpleXMLElement::addChild(string $qualifiedName, ?string $value = null, ?string $namespace = null): ?SimpleXMLElement, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Suin\RSSWriter\SimpleXMLElement.php on line 17

The Suin\RSSWriter\SimpleXMLElement.php file should be updated such that line 17:

public function addChild($name, $value = null, $namespace = null)

should become:

public function addChild(string $qualifiedName, ?string $value = null, ?string $namespace = null): ?static

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant