New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FOLIO barcodes are nil-able and ruby doesn't like sorting strings vs nil #975

Merged

corylown merged 1 commit into main from folio-barcode-sort

Jul 14, 2023

Member

cbeer commented Jul 14, 2023 •

edited

Loading

Fixes:

     ArgumentError:
       comparison of Array with Array failed
     Shared Example Group: "records match" called from ./spec/integration/compare_sirsi_and_folio_spec.rb:146
     # ./lib/traject/config/sirsi_config.rb:2226:in `each'
     # ./lib/traject/config/sirsi_config.rb:2226:in `min_by'


          FOLIO barcodes are nil-able and ruby doesn't like sorting strings vs nil

d43c13a

corylown approved these changes

View reviewed changes

corylown merged commit 2e07673 into main

2 checks passed

corylown deleted the folio-barcode-sort branch

July 14, 2023 16:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet