Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out staffOnly notes #983

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Filter out staffOnly notes #983

merged 1 commit into from
Jul 18, 2023

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Jul 17, 2023

Fixes #976

@cbeer
Copy link
Member

cbeer commented Jul 17, 2023

Don't items and holdings also have notes, or is FOLIO taking care of that already?

@jcoyne
Copy link
Contributor Author

jcoyne commented Jul 17, 2023

Items and holdings notes aren't the ones showing up in searchworks:

This instance has an "staffOnly" item note ("tf:EAST-ASIA 07/28/22 batch"), but that doesn't show up currently https://searchworks-folio-dev.stanford.edu/view/4214746, so I don't think we need to change any behavior for item note.

This instance has a "staffOnly" holding note ("visib 100 percent as of 2016-05"), but it doesn't show up in searchworks: https://searchworks-folio-dev.stanford.edu/view/L337191

@cbeer cbeer merged commit 9a59f0b into main Jul 18, 2023
2 checks passed
@cbeer cbeer deleted the filter-notes branch July 18, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suppress staff-only notes from the indexer
2 participants