Move MIGRATE-ERR suppression into FolioRecord#sirsi_holdings instead of in the query #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
approved these changes
Jul 18, 2023
cbeer
added a commit
that referenced
this pull request
Jul 18, 2023
Regression from #985 now that the `map` can break early.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Items aren't guaranteed to have location data (we also have to check holdings locations).
I think it's also a little confusing for debugging to suppress the data at the query level. It also seems like we probably don't want to go down the eresources path for instances with migrate-err holdings (which we do for any instance without items), so it's probably safer to filter these out after doing the query.