Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip subfield 0 data that starts with (SIRSI) #990

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Strip subfield 0 data that starts with (SIRSI) #990

merged 1 commit into from
Jul 19, 2023

Conversation

cbeer
Copy link
Member

@cbeer cbeer commented Jul 18, 2023

These aren't present in the Symphony MARC record and make looking for indexing differences annoying.

jcoyne
jcoyne reviewed Jul 19, 2023
View reviewed changes
Copy link
Contributor

@jcoyne jcoyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a test?

@cbeer
Copy link
Member Author

cbeer commented Jul 19, 2023

Sure, although compare_sirsi_and_folio is a pretty good test for this.

jcoyne
jcoyne approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@jcoyne jcoyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbeer thanks. I agree the comparison is a good test now, but eventually we'll be removing the comparison, right? It's good to have one that is more permanent.

@cbeer
Copy link
Member Author

cbeer commented Jul 19, 2023

Hopefully this logic is only as permanent as our interesting in comparing data against Symphony 🤷‍♂️

@jcoyne jcoyne merged commit 23aefd6 into main Jul 19, 2023
2 checks passed
@jcoyne jcoyne deleted the strip-0 branch July 19, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcoyne jcoyne jcoyne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbeer @jcoyne