Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discussion the DimensionContentQueryEnhancer #196

Open
4 tasks
alexander-schranz opened this issue Sep 17, 2021 · 0 comments
Open
4 tasks

Discussion the DimensionContentQueryEnhancer #196

alexander-schranz opened this issue Sep 17, 2021 · 0 comments
Labels
To Discuss The core team has to decide if this will be implemented
Milestone
Stable Release

Comments

@alexander-schranz
Copy link
Member

The DimensionContentQueryEnhancer was added in https://github.com/sulu/SuluContentBundle/pull/190/files#diff-d0965c4882e1b07758f0ec24a449a9995a90d1b16cb1bb2e08bf58f69d46556f.

The following things need to be discussed before stable release.

  • How to make the DimensionContentQueryEnhancer extendable
    • Add DimensionContentQueryEnhancerVisitor?
      • Move exist logic to multiple Visitors?
  • How to add group and with selects
  • How to make the group and with selects extendable?
    • Add them as part part of the Visitor Interface provide Abstract class so not every method need to be implemented?
  • Adjust that Content is loaded for Preview and other things over the Models Repository and not over ContentResolver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
To Discuss The core team has to decide if this will be implemented
Projects
None yet
Milestone
Stable Release
Development

No branches or pull requests
1 participant
@alexander-schranz