Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable limit and pagination to the SearchController #81

Open
alexandersch opened this issue Mar 31, 2021 · 2 comments
Open

Add configurable limit and pagination to the SearchController #81

alexandersch opened this issue Mar 31, 2021 · 2 comments
Labels
Feature New functionality not yet included in the Bundle

Comments

@alexandersch
Copy link

Having the limit configureable and make it possible to have a page parameter like it is in the smart content would be great for the search controller. This is just a reminder for anyone that wants to implement this if not by myself.

@alexander-schranz alexander-schranz added the Feature New functionality not yet included in the Bundle label Mar 31, 2021
@niklasnatter
Copy link
Contributor

niklasnatter commented Apr 2, 2021

Thanks for reporting! I think this would be useful too (maybe even in the WebsiteSearchController of the sulu/sulu package).

I think it should be relatively easy to implement this as the SearchManager of the massive/search-bundle already supports pagination. As a workaround, you can overwrite the SearchController service in your project at the moment.

@alexander-schranz
Copy link
Member

Not sure if the limit should be a query parameter. Atleast there should be a max_limit (default: 100) configuration so the api does not allow to load everything because loading all could produce a high load average on server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New functionality not yet included in the Bundle
Projects
None yet
Development

No branches or pull requests

3 participants