Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.2.2] test_resampled_wcs.py::test_2d fails with Astropy 6.1.3 #758

Closed
olebole opened this issue Aug 31, 2024 · 1 comment
Closed

[2.2.2] test_resampled_wcs.py::test_2d fails with Astropy 6.1.3 #758

olebole opened this issue Aug 31, 2024 · 1 comment

Comments

@olebole
Copy link

olebole commented Aug 31, 2024

Describe the bug

When running with the recently released Astropy 6.1.3 on Debian unstable, I see the following failure:

_______________________ test_2d[celestial_2d_ape14_wcs] ________________________

celestial_wcs = <astropy.wcs.wcsapi.conftest.Celestial2DLowLevelWCS object at 0x7f313011b8c0>

    @pytest.mark.parametrize('celestial_wcs',
                             ['celestial_2d_ape14_wcs', 'celestial_2d_fitswcs'],
                             indirect=True)
    def test_2d(celestial_wcs):
[...]    
        celestial = wcs_hl.pixel_to_world(*pixel_array)
        assert isinstance(celestial, SkyCoord)
        assert_quantity_allclose(celestial.ra, world_array[0] * u.deg)
        assert_quantity_allclose(celestial.dec, world_array[1] * u.deg)
    
        EXPECTED_2D_REPR = EXPECTED_2D_REPR_NUMPY2 if np.__version__ >= '2.0.0' else EXPECTED_2D_REPR_NUMPY1
>       assert str(wcs) == EXPECTED_2D_REPR
E       AssertionError: assert 'ResampledLow...  1  yes  yes' == 'ResampledLow...  1  yes  yes'
E         
E         Skipping 112 identical leading characters in diff, use -v to show
E         - order): (2.3333333333333335, 15.0)
E         + order): (2, 15)
E           
E           Pixel Dim  Axis Name  Data size  Bounds
E                   0  None              15  (-2.5, 12.5)...
E         
E         ...Full output truncated (12 lines hidden), use '-vv' to show

../../../ndcube/wcs/wrappers/tests/test_resampled_wcs.py:119: AssertionError

This happens for both celestial_wcs parameters.
Full test log

This is a regression by the Astropy update; with Astropy 6.1.2 the tests pass.

To Reproduce

No response

Screenshots

No response

System Details

  • ndcube 2.2.0, 2.2.2
  • Sunpy 6.0.1
  • Astropy 6.1.3
  • Numpy 1.26.4
  • Python 3.12.5

I tested ndcube 2.2.0 from Debian testing; however this also when I try to update the package to 2.2.2.

Installation method

Linux package manager

@Cadair
Copy link
Member

Cadair commented Oct 17, 2024

Thanks @olebole I think this will be fixed in the shortly-to-be-release 2.2.3 and has been fixed on main for a bit.

@Cadair Cadair closed this as completed Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants