Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should enhance functions take a map and return a map? #189

Closed
hayesla opened this issue Mar 5, 2024 · 3 comments
Closed

Should enhance functions take a map and return a map? #189

hayesla opened this issue Mar 5, 2024 · 3 comments

Comments

@hayesla
Copy link
Member

hayesla commented Mar 5, 2024

Describe the feature

At the moment, sunkit_image.enhance.mgn takes data and then returns data. A user has to pass extract the data from a map, apply the function, then reconstruct a map, wouldnt it make more sense that this (and then any other function in sunkit_image.enhance` take and return a map?

@Ghaithq
Copy link
Contributor

Ghaithq commented Mar 5, 2024

Isn't this the case? It is stated in the code documentation that it does return a map depending on the input.

        Normalized image. If a map is input, a map is returned with new data
        and the same metadata

@wtbarnes
Copy link
Member

wtbarnes commented Mar 5, 2024

Yeah this was closed a while back by #135.

@wtbarnes wtbarnes closed this as completed Mar 5, 2024
@wtbarnes
Copy link
Member

wtbarnes commented Mar 5, 2024

I'm closing this as I'm pretty sure this is already possible but feel free to reopen if for some reason I'm missing something!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants