Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnmapProcessMemory: Verify that the src page list == dst page list. #479

Open
todo bot opened this issue Sep 18, 2019 · 0 comments
Open

UnmapProcessMemory: Verify that the src page list == dst page list. #479

todo bot opened this issue Sep 18, 2019 · 0 comments
Assignees
Labels
todo 🗒️ Created by the todo bot

Comments

@todo
Copy link

todo bot commented Sep 18, 2019

In UnmapProcessMemory, we don't ensure that src_address is correct, that is, we don't check that the frames in the dst match the frame in the src. HOS/NX does this by building a PageList (essentially a vector of frames) and comparing them.
We could do something similar by iterating over the Mappings and checking if their Frames + PhysOffset are equals.


// TODO: UnmapProcessMemory: Verify that the src page list == dst page list.
// BODY: In UnmapProcessMemory, we don't ensure that src_address is correct,
// BODY: that is, we don't check that the frames in the dst match the frame
// BODY: in the src. HOS/NX does this by building a PageList (essentially
// BODY: a vector of frames) and comparing them.
// BODY:
// BODY: We could do something similar by iterating over the Mappings and
// BODY: checking if their Frames + PhysOffset are equals.
// Unmap.
while size != 0 {


This issue was generated by todo based on a TODO comment in 27ab3e4 when #458 was merged. cc @roblabla.
@todo todo bot added the todo 🗒️ Created by the todo bot label Sep 18, 2019
@todo todo bot assigned roblabla Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
todo 🗒️ Created by the todo bot
Projects
None yet
Development

No branches or pull requests

1 participant