Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the handling of PROCESS_STATE_CHANGED to a single dedicated task. #543

Open
todo bot opened this issue Nov 22, 2019 · 0 comments
Open

Move the handling of PROCESS_STATE_CHANGED to a single dedicated task. #543

todo bot opened this issue Nov 22, 2019 · 0 comments
Assignees
Labels
project-loader Related to loader todo 🗒️ Created by the todo bot type-refactoring Cleanup and refactoring tasks

Comments

@todo
Copy link

todo bot commented Nov 22, 2019

We currently handle PROCESS_STATE_CHANGED signaling in one task per launched process. This is a ridiculous amount of overhead.


// TODO: Move the handling of PROCESS_STATE_CHANGED to a single dedicated task.
// BODY: We currently handle PROCESS_STATE_CHANGED signaling in one
// BODY: task per launched process. This is a ridiculous amount of
// BODY: overhead.
workqueue.clone().spawn(FutureObj::new(Box::new(async move {
let mut current_state = ProcessState::Created;
while current_state != ProcessState::Exited {
if let Err(err) = process_static.wait_async(workqueue.clone()).await {
error!("{:?}", err);
return;
}


This issue was generated by todo based on a TODO comment in c2a92a4 when #542 was merged. cc @roblabla.
@todo todo bot added the todo 🗒️ Created by the todo bot label Nov 22, 2019
@todo todo bot assigned roblabla Nov 22, 2019
@roblabla roblabla added project-loader Related to loader type-refactoring Cleanup and refactoring tasks labels Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project-loader Related to loader todo 🗒️ Created by the todo bot type-refactoring Cleanup and refactoring tasks
Projects
None yet
Development

No branches or pull requests

1 participant