Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock binary dependencies #648

Closed
wants to merge 1 commit into from
Closed

Lock binary dependencies #648

wants to merge 1 commit into from

Conversation

roblabla
Copy link
Member

Make sure binary dependencies are built with their dependencies locked, so we don't end up with problems if the dependencies don't support our nightly anymore.

Fixes #647
Fixes #585

@roblabla
Lock binary dependencies
1548155 
Make sure binary dependencies are built with their dependencies locked, so we don't end up with problems if the dependencies don't support our nightly anymore.
@roblabla
Copy link
Member Author

Right, so --locked doesn't work on crates.io dependencies. Ain't that great. Let's move mkisofs-rs and xargo to git deps, and pin the git version.

@roblabla
Copy link
Member Author

Oh, heh, actually they are, but mkisofs-rs doesn't have one. @Thog we'll need to republish it.

@roblabla
Copy link
Member Author

Fixed in #650

@roblabla roblabla closed this Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marysaka marysaka marysaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build gets errors on macOS Big Sur Build with --locked on CI
2 participants
@roblabla @marysaka