Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileClientModel initializes FileClientGroup without proper points_class #68

Open
jmmgenerac opened this issue Oct 1, 2022 · 1 comment

Comments

@jmmgenerac
Copy link
Contributor

jmmgenerac commented Oct 1, 2022

Because the FileClientModel initializes its FileClientGroup parent class without referencing the FileClientPoint class, all points in the FileClientModel have the generic device.Point class instead of the file.client.FileClientPoint class.

One benefit of using the FileClientPoint class is that it contains a read() method, unlike the device.Point class which does not.

FileClientGroup.__init__(self, gdef=gdef, model=self, model_offset=0, group_len=self.model_len, data=data,
data_offset=0, group_class=group_class)

Should be:

 FileClientGroup.__init__(self, gdef=gdef, model=self, model_offset=0, group_len=self.model_len, data=data, 
                          data_offset=0, group_class=group_class, point_class=point_class)
@jmmgenerac
Copy link
Contributor Author

jmmgenerac commented Oct 1, 2022

See pull request #69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant