Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question]: Why Compose Auth plugin native Google One Tap login showing old dialog? #797

Open
1 task done
Premjit-Developer opened this issue Nov 29, 2024 · 3 comments
Open
1 task done
Labels
question Further information is requested

Comments

@Premjit-Developer
Copy link

General info

What is your question?

This is the Compose Auth plugin googleNativeLogin() implemented version showing old dialog

WhatsApp Image 2024-11-29 at 9 57 46 PM

And this is my own Google One Tap login with Credential-manager implemented version, it is showing the latest One Tap login bottomsheet.

WhatsApp Image 2024-11-29 at 9 57 47 PM

Relevant log output (optional)

No response

@Premjit-Developer Premjit-Developer added the question Further information is requested label Nov 29, 2024
@jan-tennert
Copy link
Collaborator

Checkout #643

@Premjit-Developer
Copy link
Author

It feels awkward to switch from GetGoogleIdOption to GetSignInWithGoogleOption, as it only changes the look without adding much value. I don’t see the need for an additional GetSignInWithGoogleOption when I can create a manual "Login with Google" button and use GetGoogleIdOption, which already works well and has a great BottomSheet UI.

Moreover, GetGoogleIdOption is still recommended in the official snippets. It would be much better if there were an option to let developers choose whether they want to use GetGoogleIdOption or GetSignInWithGoogleOption, providing flexibility for different use cases.

https://developer.android.com/identity/sign-in/credential-manager-siwg#sign-in

@jan-tennert
Copy link
Collaborator

jan-tennert commented Dec 1, 2024

Well, the dialog option is recommended for a "Sign in with Google"-Button, the bottom sheet to automatically prompt the user to sign in. And you can disable the bottom sheet option in your Google settings. But I can look into making this configurable.

Add the Sign in with Google button to your app's UI. The Sign in with Google button offers a streamlined way for users to use their existing Google Accounts to sign up or sign in to Android apps. Users will click the Sign in with Google button if they dismiss the bottom sheet UI, or if they explicitly want to use their Google Account for sign up and sign in. For developers, this means easier user onboarding and reduced friction during sign-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants