Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update migration tests docs #1096

Open
olirice opened this issue Aug 6, 2024 · 0 comments
Open

Update migration tests docs #1096

olirice opened this issue Aug 6, 2024 · 0 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@olirice
Copy link
Contributor

olirice commented Aug 6, 2024

The migration test docs
https://github.com/supabase/postgres/blob/develop/nix/docs/migration-tests.md

Have an example showing how to reference builds by git sha

OLD_GIT_VERSION=...
NEW_GIT_VERSION=...

nix run github:supabase/nix-postgres#migration-test \
  $(nix build "github:supabase/nix-postgres/$OLD_GIT_VERSION#psql_15/bin") \
  $(nix build "github:supabase/nix-postgres/$NEW_GIT_VERSION#psql_15/bin") \
  pg_upgrade

that doesn't function as nix build "github:supabase/nix-postgres/$OLD_GIT_VERSION#psql_15/bin" does not return a nix path as it appears to expect

It does still work if you reference a major version directly

nix run github:supabase/nix-postgres#migration-test \
  15
  15
  pg_upgrade
@olirice olirice added bug Something isn't working documentation Improvements or additions to documentation and removed bug Something isn't working labels Aug 6, 2024
@samrose samrose self-assigned this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants